Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename V2's `MergedDirectories` to `DirectoriesToMerge` #7730

Merged

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented May 14, 2019

MergedDirectories is a confusing name because it suggests that the directories are already merged (i.e. the output), whereas really this is the type of the directories that will be merged (i.e. the input).

Refer to #7699 (comment).

@Eric-Arellano Eric-Arellano requested review from stuhood and illicitonion May 14, 2019

@Eric-Arellano Eric-Arellano marked this pull request as ready for review May 14, 2019

@illicitonion
Copy link
Contributor

left a comment

Thanks!

@Eric-Arellano Eric-Arellano merged commit 26805bd into pantsbuild:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:merged-directories-rename branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.