Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down logging when making ShardedLmdbs #7733

Merged

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 15, 2019

No description provided.

@illicitonion illicitonion requested a review from Eric-Arellano May 15, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Great change!

Please tighten the PR description to something like "Tone down logging for Rust making databases". Ideally this will reflect that it's a very small-scoped PR - you are not toning down CI for dozens of places.

@illicitonion illicitonion changed the title Tone down logging Tone down logging when making ShardedLmdbs May 15, 2019

@stuhood stuhood merged commit 74c3378 into pantsbuild:master May 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:dwagnerhall/tracelogging/shardedlmdb branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.