Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalidation of awslambda bundling. #7744

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
4 participants
@benjyw
Copy link
Contributor

commented May 16, 2019

Fixes #7743.

@stuhood
Copy link
Member

left a comment

Thanks Bnejy!

(talk about a footgun, oy... we really ought to just go ahead and toggle the default and to hell with what breaks)

@benjyw

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

I was just thinking that. We can probably grep for all remaining cases that don't set it, and set it explicitly to False there.

@ngortheone

This comment has been minimized.

Copy link

commented May 16, 2019

Thanks!

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you for looking into this!

@benjyw benjyw merged commit ab95c36 into pantsbuild:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_awslambda_invalidation branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.