Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence publishing uses correct text types #7746

Merged

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 17, 2019

Without this change, actually publishing to Confluence fails with encoding errors.

Specifically:
user needs converting because xmlrpclib hard-codes what kinds it can encode, and doesn't count future's newstr.
url needs converting because it's detected as a newbytes which has its encode disabled. Maybe this should instead be calling binary_type(...).encode("utf-8")?

Confluence publishing uses correct text types
Without this change, actually publishing to Confluence fails with encoding errors.

@illicitonion illicitonion merged commit 13bc06d into pantsbuild:master May 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/py3/confluencepublishing branch May 17, 2019

illicitonion added a commit that referenced this pull request May 17, 2019

Confluence publishing uses correct text types (#7746)
Without this change, actually publishing to Confluence fails with encoding errors.

Specifically:
user needs converting because xmlrpclib hard-codes what kinds it can encode, and doesn't count future's newstr.
url needs converting because it's detected as a newbytes which has its `encode` disabled. Maybe this should instead be calling `binary_type(...).encode("utf-8")`?

@stuhood stuhood added this to the 1.16.x milestone May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.