Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require `ack`, `grep` can do the job. #7753

Merged
merged 2 commits into from May 18, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented May 17, 2019

I don't have ack installed and hit an error in shell checks. Since we
already use grep, stick with it at the cost of a tiny bit more
verbosity.

jsirois added some commits May 17, 2019

Don't require `ack`, `grep` can do the job.
I don't have ack installed and hit an error in shell checks. Since we
already use grep, stick with it at the cost of a tiny bit more
verbosity.

@jsirois jsirois requested review from illicitonion and Eric-Arellano May 17, 2019

@jsirois

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

NB: shellcheck --shell=bash build-support/bin/check_shell.sh is green.

bad_output="$(find ./* -name '*.sh' -print0 \
| xargs -0 grep -H 'curl '| grep -v 'curl --fail' | cut -d: -f1 \
| grep -v build-support/bin/check_shell.sh \
|| :)"

This comment has been minimized.

Copy link
@stuhood

stuhood May 17, 2019

Member

:)

@Eric-Arellano
Copy link
Contributor

left a comment

Thank you for running shellcheck!

@jsirois jsirois merged commit 97a6c18 into pantsbuild:master May 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:ack/nack branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.