Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require `ack`, `grep` can do the job. #7753

Merged
merged 2 commits into from May 18, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

Follow whitespace conventions in file.

  • Loading branch information...
jsirois committed May 17, 2019
commit c3a0fe053ee11adc5ee3af94c49ae20ba84cf19d
@@ -20,6 +20,7 @@ bad_output="$(find ./* -name '*.sh' -print0 \
| xargs -0 grep -H 'curl '| grep -v 'curl --fail' | cut -d: -f1 \
| grep -v build-support/bin/check_shell.sh \
|| :)"

This comment has been minimized.

Copy link
@stuhood

stuhood May 17, 2019

Member

:)


if [[ -n "${bad_output}" ]]; then
echo >&2 "Found bash files with curl not followed by --fail."
echo >&2 "This is bad because 404s and such will end up with error pages in the output files."
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.