Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align mypy interpreter constraint with reality. #7754

Merged
merged 1 commit into from May 18, 2019

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

commented May 17, 2019

The mypy tool actually requires python 3.5+. On a machine with 3.4 and
3.x higher the minimum interpreter selection scheme would pick 3.4 and
fail.

Fixup interpreter constraints to avoid this erroneous error and correct
the corresponding test. Cleanup dead code in
interpreter_selection_utils.py along the way.

Align mypy interpreter constraint with reality.
The mypy tool actually requires python 3.5+. On a machine with 3.4 and
3.x higher the minimum interpreter selection scheme would pick 3.4 and
fail.

Fixup interpreter constraints to avoid this erroneous error and correct
the corresponding test. Cleanup dead code in
interpreter_selection_utils.py along the way.

@jsirois jsirois requested review from Eric-Arellano and tdyas May 17, 2019

@stuhood
Copy link
Member

left a comment

Thanks!

@jsirois jsirois merged commit 94d6f20 into pantsbuild:master May 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:mypy/correct-interp-constraints branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.