Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patched protobuf with RUSTSEC-2019-0003 fix. #7770

Merged
merged 1 commit into from May 20, 2019
Commits on May 20, 2019
  1. Use patched protobuf with RUSTSEC-2019-0003 fix.

    jsirois committed May 20, 2019
    A crates index patch was needed here to ensure both our crates and
    transitive dependent crates saw the same rust-protobuf. Without this we
    hit many errors like:
    ```
       Compiling bazel_protos v0.0.1 (/home/jsirois/dev/pantsbuild/jsirois-pants/src/rust/engine/process_execution/bazel_protos)
    error[E0277]: the trait bound `gen::bytestream::ReadRequest: protobuf::core::Message` is not satisfied
      --> process_execution/bazel_protos/src/gen/bytestream_grpc.rs:23:42
       |
    23 |     req_mar: ::grpcio::Marshaller { ser: ::grpcio::pb_ser, de: ::grpcio::pb_de },
       |                                          ^^^^^^^^^^^^^^^^ the trait `protobuf::core::Message` is not implemented for `gen::bytestream::ReadRequest`
       |
       = note: required by `grpcio::codec::pb_codec::ser`
    ```
    
    Fixes #7760
You can’t perform that action at this time.