Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake serverset test #7780

Merged
merged 2 commits into from May 22, 2019

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 21, 2019

This code is time-sensitive, so pull the timeout check into around the
assert, rather than around the loop.

Fixes #7756

Deflake serverset test
This code is time-sensitive, so pull the timeout check into around the
assert, rather than around the loop.

@illicitonion illicitonion requested review from jsirois and blorente May 21, 2019

@jsirois
Copy link
Member

left a comment

This seems fine. In the small though expect_only_good should probably assert it sees only good more than once; ie: that its not just performing a single sample and happening to get good in the face of a faulty implementation that is letting bad leak in. Of course none of this is actually going on, but expect_only_good is suspicious in the small.

@illicitonion illicitonion merged commit 8c50aea into pantsbuild:master May 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/serverset/deflake branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.