Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symlinking logic in the presence of broken links. #7791

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
4 participants
@benjyw
Copy link
Contributor

commented May 22, 2019

No description provided.

@benjyw benjyw requested review from illicitonion and stuhood May 22, 2019

@illicitonion
Copy link
Contributor

left a comment

Thanks!

if not os.path.exists(jdk_home_symlink):
safe_delete(jdk_home_symlink) # In case it's a broken symlink.

This comment has been minimized.

Copy link
@illicitonion

illicitonion May 22, 2019

Contributor

These branches are now the same, so could be unified into a single if branch if you fancied it. Or not :)

This comment has been minimized.

Copy link
@benjyw

benjyw May 23, 2019

Author Contributor

Done.

@benjyw benjyw merged commit 817f7f6 into pantsbuild:master May 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_symlinking branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.