Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc bug for `--fast` in testrunner_task_mixin #7797

Merged
merged 4 commits into from May 24, 2019

Conversation

Projects
None yet
4 participants
@grimreaper
Copy link
Contributor

commented May 23, 2019

Problem

JUnit (and other test runners) claims to use PyTest.

Solution

Don't claim to use python.

Result

Humans get less confused.

Fix doc bug for `--test` in testrunner_task_mixin
Without this change junit incorrectly claims to use a "single pytest invocation" by default.
@stuhood
Copy link
Member

left a comment

Thanks!

@stuhood stuhood changed the title Fix doc bug for `--test` in testrunner_task_mixin Fix doc bug for `--fast` in testrunner_task_mixin May 23, 2019

@stuhood

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Fixed the title.

@grimreaper

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

I am impressed at my own ability to have two bugs in a one-line documentation code change
I blame editing in a browser

@stuhood

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Only flakies. Merging.

@stuhood stuhood merged commit bdb7b9f into pantsbuild:master May 24, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.