Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc bug for `--fast` in testrunner_task_mixin #7797

Merged
merged 4 commits into from May 24, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -408,7 +408,7 @@ def register_options(cls, register):
# https://github.com/pantsbuild/pants/issues/5073

register('--fast', type=bool, default=True, fingerprint=True,
help='Run all tests in a single pytest invocation. If turned off, each test target '
help='Run all tests in a single invocation. If turned off, each test target '
'will run in its own pytest invocation, which will be slower, but isolates '
This conversation was marked as resolved by grimreaper

This comment has been minimized.

Copy link
@codealchemy

codealchemy May 23, 2019

Contributor

Should pytest be removed here as well?

Suggested change
'will run in its own pytest invocation, which will be slower, but isolates '
'will run in its own invocation, which will be slower, but isolates '

This comment has been minimized.

Copy link
@grimreaper

grimreaper May 23, 2019

Author Contributor

fixed. I had searched using the browser for 'pytest' and didn't even notice the next line!

This comment has been minimized.

Copy link
@codealchemy

codealchemy May 23, 2019

Contributor

Ah, for some reason the suggestion dropped some whitespace leading #7797 (comment) - apologies for that.

'tests from process-wide state created by tests in other targets.')
register('--chroot', advanced=True, fingerprint=True, type=bool, default=False,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.