Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust 1.35.0 #7798

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented May 23, 2019

No description provided.

// the underlying linker. This avoids "missing symbol" errors for Python symbols
// (e.g. `_PyImport_ImportModule`) at build time when bundling the CFFI C sources.
// The missing symbols will instead by dynamically resolved in the address space of the parent
// binary (e.g. `python`) at runtime - obviating a need to link to libpython.

This comment has been minimized.

Copy link
@Eric-Arellano

Eric-Arellano May 23, 2019

Contributor

By obviating, you mean "removing", right? Consider a more accessible synonym like "removing".

This comment has been minimized.

Copy link
@illicitonion

illicitonion May 24, 2019

Author Contributor

This was just copied from a now-deleted file. But I agree - reworded :)

@stuhood
Copy link
Member

left a comment

Thanks!

@stuhood stuhood merged commit 050c4d0 into pantsbuild:master May 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:dwagnerhall/rust-1.35.0 branch May 24, 2019

@@ -62,7 +62,6 @@ function _build_native_code() {
# Builds the native code, and echos the path of the built binary.

(
cd "${REPO_ROOT}"

This comment has been minimized.

Copy link
@stuhood

stuhood May 25, 2019

Member

This edit broke using pants from other repos... was it necessary for something here?

This comment has been minimized.

Copy link
@illicitonion

illicitonion May 28, 2019

Author Contributor

Aha! No, it wasn't necessary; this cd used to do two things (ensure we're in a child of the directory containing .cargo, and ensure we're a child of the directory containing rust-toolchain); I removed it because the first is now no longer necessary, forgetting that the second is. Will re-add with a comment.

illicitonion added a commit that referenced this pull request May 31, 2019

Change into repo dir when running cargo (#7827)
This means the rust-toolchain file is correctly detected when running outside of the pants checkout.

This was accidentally removed in #7798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.