Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scalastyle to the v2 unit test blacklist #7800

Merged

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

commented May 24, 2019

Problem

I don't repro a failure locally, but this one has failed in two PRs recently. I'm guessing that there is a concurrency issue with creating lots of nailgun servers at once (a thing that the hermetic API does not defend against, unfortunately).

Solution

Blacklist to run under v1 (ie, without concurrency).

@stuhood stuhood requested a review from Eric-Arellano May 24, 2019

@stuhood

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

Going to go ahead and merge without waiting for CI.

@stuhood stuhood merged commit 8add7c7 into pantsbuild:master May 24, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/move-scalastyle-to-the-v2-blacklist branch May 24, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Hm not sure how this slipped through. Thanks for adding to the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.