Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade isort and add/fix support for skip config. #7804

Merged
merged 1 commit into from May 27, 2019

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented May 27, 2019

We upgrade isort to pick up support for skip_glob and fix skipping for
both skip and skip_glob directives by passing --filter-files to
inform isort to honor any skip configuration even when we pass all file
names to sort explicitly.

Upgrade isort and add/fix support for skip config.
We upgrade isort to pick up support for `skip_glob` and fix skipping for
both `skip` and `skip_glob` directives by passing `--filter-files` to
inform isort to honor any skip configuration even when we pass all file
names to sort explicitly.
@benjyw

benjyw approved these changes May 27, 2019

@jsirois jsirois merged commit 421834c into pantsbuild:master May 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:isort/upgrade branch May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.