Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply final set of Shellcheck fixes and turn on in CI #7832

merged 16 commits into from Jun 3, 2019
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now


Apply Danny's fix for SC2044 (iterating over find output)

  • Loading branch information...
Eric-Arellano committed Jun 3, 2019
commit 23f525be90939c9ae888214b15b6dde61c589c13
@@ -565,8 +565,7 @@ function adjust_wheel_platform() {
local src_plat="$1"
local dst_plat="$2"
local dir="$3"
# shellcheck disable=SC2044
for src_whl in $(find "${dir}" -name '*'"${src_plat}.whl"); do
find "$dir" -type f -name "*${src_plat}.whl" | while read -r src_whl; do
local dst_whl=${src_whl/$src_plat/$dst_plat}
mv -f "${src_whl}" "${dst_whl}"
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.