Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Extract out `resolve_requirements` V2 rule for creating PEXes with requirements #7846
One of its main pieces of logic that should be factored out is creating a PEX with the desired requirements, entry point, and interpreter constraints. This will presumably be useful for other V2 rules, so should not be coupled to the Pytest runner.
Also, it was found in #7795 that this requirements PEX is causing ~75% of the performance issues for the V2 Pytest runner. Having it extracted out into its own rule will make it easier to develop, test, and optimize.
Create a generic rule, along with dedicated tests.
Eric-Arellano left a comment
Final step before this will be ready to review is figuring out testing, both what to do with the original
I don't know how to meaningfully test this file. I think we would want ~integration tests that set up the entire PEX with dependencies, then confirm the PEX works? Maybe test the different permutations like setting an entry point and setting interpreter constraints?