Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply isort fixes #7857

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 5, 2019

In #7849, the lint shard was failing due to isort complaining about a file whose comment had to be updated.

When running ./pants --cache-ignore fmt.isort tests/python:: src/python:: build-support/bin:: pants-plugins:: on master, indeed several files have issues. They were not caught because isort.sh only runs against changed files.

@Eric-Arellano Eric-Arellano requested a review from jsirois Jun 5, 2019

@jsirois

jsirois approved these changes Jun 5, 2019

jsirois added a commit to jsirois/pants that referenced this pull request Jun 5, 2019

Remove an old redundant .isort.cfg.
This came up in discussion surrounding pantsbuild#7857.

@Eric-Arellano Eric-Arellano merged commit 6ab5f7a into pantsbuild:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:isort branch Jun 5, 2019

jsirois added a commit to jsirois/pants that referenced this pull request Jun 6, 2019

Remove an old redundant .isort.cfg.
This came up in discussion surrounding pantsbuild#7857.

jsirois added a commit to jsirois/pants that referenced this pull request Jun 9, 2019

Remove an old redundant .isort.cfg.
This came up in discussion surrounding pantsbuild#7857.

jsirois added a commit that referenced this pull request Jun 9, 2019

Remove an old redundant .isort.cfg. (#7859)
This came up in discussion surrounding #7857.

cattibrie added a commit to cattibrie/pants that referenced this pull request Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.