Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc doesn't re-snapshot jars produced by zinc #7858

Merged

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented Jun 5, 2019

Instead it re-uses existing digests from the classpath product.

A follow-up change will also stop re-snapshotting jars produced by rsc.

rsc doesn't re-snapshot jars produced by zinc
Instead it re-uses existing digests from the classpath product.

A follow-up change will also stop re-snapshotting jars produced by rsc.

@illicitonion illicitonion requested review from stuhood and cosmicexplorer Jun 5, 2019

@stuhood

stuhood approved these changes Jun 5, 2019

Copy link
Member

left a comment

Thanks!

main = 'rsc.cli.Main'
tool_name = 'rsc'
with self.context.new_workunit(tool_name) as wu:
return self.execution_strategy_enum.resolve_for_enum_variant({
self.HERMETIC: lambda: self._runtool_hermetic(
main, tool_name, args, distribution,
tgt=tgt, input_files=input_files, input_digest=input_digest, output_dir=output_dir),
tgt=tgt, input_digest=input_digest, output_dir=output_dir),

This comment has been minimized.

Copy link
@stuhood

stuhood Jun 5, 2019

Member

👍

@cosmicexplorer
Copy link
Contributor

left a comment

Great!

@stuhood

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

I pushed one commit to drop an unused import.

@illicitonion illicitonion merged commit 20ac870 into pantsbuild:master Jun 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/rsc/avoid-re-snapshotting branch Jun 6, 2019

stuhood added a commit that referenced this pull request Jun 7, 2019

rsc doesn't re-snapshot jars produced by zinc (#7858)
Instead it re-uses existing digests from the classpath product.

A follow-up change will also stop re-snapshotting jars produced by rsc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.