Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an old redundant .isort.cfg. #7859

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented Jun 5, 2019

This came up in discussion surrounding #7857.

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

NB: I ran ./pants fmt.isort --cache-ignore contrib/scrooge/:: with no change in sorting to vet the claimed redundancy.

@jsirois jsirois requested a review from Eric-Arellano Jun 5, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Thanks!

@jsirois jsirois force-pushed the jsirois:isort.cfg/remove_redundant branch from 99d6593 to 3823453 Jun 6, 2019

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

Re-based to hopefully pick up a fix for the persistent RscCompileIntegration.test_java_sources error this PR is seeing in CI.

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

The re-base got past the RscCompileIntegration.test_java_sources break but the un-documented NailgunTask unit test flakes under the v2 runner then broke things. I've documented in #7865 and am swapping over to squash that.

Remove an old redundant .isort.cfg.
This came up in discussion surrounding #7857.

@jsirois jsirois force-pushed the jsirois:isort.cfg/remove_redundant branch from 3823453 to e876e72 Jun 9, 2019

@jsirois jsirois merged commit d0fca92 into pantsbuild:master Jun 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:isort.cfg/remove_redundant branch Jun 9, 2019

cattibrie added a commit to cattibrie/pants that referenced this pull request Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.