Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Stabilize all tests of NailgunTask subclasses. #7866
Since there is no need to re-test nailgun behavior for each
Eric-Arellano left a comment
Great. This looks very sensible to me.
My only feedback is to take a pass over the title and PR description. For example, title could be "Stabilize all tests of Nailgun subclasses by changing execution strategy". For the performance change that you mentioned in your comment, it would be helpful to include in the PR description. Reason I'm suggesting this is it took me until reaching
Thank you for taking the time to fix this!
referenced this pull request
Jun 8, 2019
One unwritten rule I follow in all my commits is to match linux / git commit message norms: https://git-scm.com/docs/git-commit#_discussion - In particular, 50 character max subjects, 72 character max message body lines.
I left the title as-is as a result (47 chars as-is) but moved the last body sentence to be the first since it already explains the the fix was to change the execution strategy - in particular "turn off nailgunning in unit tests".