Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug log for jvm target compile time ; fix execution graph display #7873

Merged

Conversation

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

commented Jun 8, 2019

Problem

We print out lots of relevant information to zinc/rsc compile performance with -ldebug, including a drawing of the execution graph, and the timings of any v2 process executions. We write per-target compile data to the run tracker which can be queried afterwards, but it would be nice to have that information written to the terminal for interactive or hacky screen-scraping use cases.

Solution

  • Write a debug log of the per-target compile data in self._record_target_stats().
  • Flip the direction of the ExecutionGraph arrows.

Result

The debug logging during an rsc compile should hopefully be more useful!

cosmicexplorer added some commits Jun 8, 2019

@stuhood

stuhood approved these changes Jun 8, 2019

@cosmicexplorer cosmicexplorer merged commit 97f50b7 into pantsbuild:master Jun 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

cosmicexplorer added a commit to cosmicexplorer/pants that referenced this pull request Jun 8, 2019

add debug log for jvm target compile time ; fix execution graph displ…
…ay (pantsbuild#7873)

### Problem

We print out lots of relevant information to zinc/rsc compile performance with `-ldebug`, including a drawing of the execution graph, and the timings of any v2 process executions. We write per-target compile data to the run tracker which can be queried afterwards, but it would be nice to have that information written to the terminal for interactive or hacky screen-scraping use cases.

### Solution

- Write a debug log of the per-target compile data in `self._record_target_stats()`.
- Flip the direction of the `ExecutionGraph` arrows.

### Result

The debug logging during an rsc compile should hopefully be more useful!

cattibrie added a commit to cattibrie/pants that referenced this pull request Jun 19, 2019

add debug log for jvm target compile time ; fix execution graph displ…
…ay (pantsbuild#7873)

### Problem

We print out lots of relevant information to zinc/rsc compile performance with `-ldebug`, including a drawing of the execution graph, and the timings of any v2 process executions. We write per-target compile data to the run tracker which can be queried afterwards, but it would be nice to have that information written to the terminal for interactive or hacky screen-scraping use cases.

### Solution

- Write a debug log of the per-target compile data in `self._record_target_stats()`.
- Flip the direction of the `ExecutionGraph` arrows.

### Result

The debug logging during an rsc compile should hopefully be more useful!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.