Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `DistributionLocator` dependency declarations. #7875

Merged
merged 2 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented Jun 8, 2019

This fixes all usages of DistributionLocator to declare a subsystem
dependency and removes all unused dependency declarations save for
those in the Ivy family where the tangles run deep.

Discovered working #7872.

@stuhood

stuhood approved these changes Jun 9, 2019

Copy link
Member

left a comment

Thank you!

jsirois added some commits Jun 8, 2019

Fix `DistributionLocator` dependency declarations.
This fixes all usages of `DistributionLocator` to declare a subsystem
dependency and removes all unused dependency declarations save for
those in the `Ivy` family where the tangles run deep.

Discovered working #7872.

@jsirois jsirois force-pushed the jsirois:DistributionLocator/declare branch from 96c5279 to 8677c46 Jun 9, 2019

@jsirois jsirois merged commit 384f178 into pantsbuild:master Jun 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:DistributionLocator/declare branch Jun 9, 2019

cattibrie added a commit to cattibrie/pants that referenced this pull request Jun 19, 2019

Fix `DistributionLocator` dependency declarations. (pantsbuild#7875)
This fixes all usages of `DistributionLocator` to declare a subsystem
dependency and removes all unused dependency declarations save for
those in the `Ivy` family where the tangles run deep.

Discovered working pantsbuild#7872.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.