Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add remote workunits for Zipkin trace #7897
As the purpose of the remoting is to make pants runs faster (for compile) it is very important to understand its performance. One of the nice ways is Zipkin tracing.
The result of the remote execution contains timings of different stages of the remote process that are used to create workunits to Zipkin trace.
The last part of this PR is to add a test(unitest and/or integration test).
3 times, most recently
Jun 19, 2019
Jun 27, 2019
Looks great! A couple of tiny comments, otherwise about ready to merge :)
Can you look at the first two shards on travis? There are a couple of trivial clippy things, and a reformatting needed. All the other shards look like unrelated flakes