Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't nest output directories in an empty path #7908

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented Jun 20, 2019

Before if the we had an output_directory named "" containing a file foo, we'd end up with this structure:

./[directory_with_no_name]/foo

Now we correctly create this structure:
./foo

This is specified to be a special case in the API docs:
https://github.com/bazelbuild/remote-apis/blob/a5c577357528b33a4adff88c0c7911dd086c6923/build/bazel/remote/execution/v2/remote_execution.proto#L483-L485

@Eric-Arellano
Copy link
Contributor

left a comment

I'm a little confused what we were originally doing, and what we do now. Could you please in the PR description include an example? Something like:

Before, if we had the empty path "", we would store this as "super/nested" incorrectly. Now, we properly treat this as "". See ...bazel_link... for why this is important to do.

@illicitonion

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

I'm a little confused what we were originally doing, and what we do now. Could you please in the PR description include an example? Something like:

Before, if we had the empty path "", we would store this as "super/nested" incorrectly. Now, we properly treat this as "". See ...bazel_link... for why this is important to do.

Done

@Eric-Arellano
Copy link
Contributor

left a comment

Maybe wait for someone who understands Rust better, but it all looks right.

Thanks for the PR description update!

@stuhood
Copy link
Member

left a comment

Thanks!

@illicitonion illicitonion merged commit d12a1aa into pantsbuild:master Jun 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/local-process-execution-cache/empty-output-dir branch Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.