Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize all headers to Python 3 style #7926

Merged
merged 10 commits into from Jun 22, 2019

Conversation

Projects
None yet
4 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 21, 2019

Now that we require Python 3, we can simplify our header to remove from __future__ and # encoding=utf-8 entries, which both no-op in Python 3.

We use a simple script to do this, along with updating check_header.py to only support Python 3 style headers.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Reviewers: each commit may be independently reviewed. The only non-mechanical commit is 2fd557a. 7d896e0 had to be done manually (changing testprojects), but is same type of mechanical change.

@benjyw

benjyw approved these changes Jun 21, 2019

@ity

ity approved these changes Jun 21, 2019

@Eric-Arellano Eric-Arellano merged commit ea74e99 into pantsbuild:master Jun 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:py3-headers branch Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.