Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--concurrent` flag, which overrides `--enable-pantsd` #7944

Merged
merged 1 commit into from Jun 24, 2019

Conversation

Projects
None yet
4 participants
@blorente
Copy link
Contributor

commented Jun 24, 2019

Problem

We want for users to be able to run concurrent pants runs. This, essentially, means turning off pantsd. This PR implements that flag, and just doesn't even try to use pantsd if --concurrent is set.

Some more context: #7913 (comment)

Feel free to push stuff on top of this.

@ity

ity approved these changes Jun 24, 2019

Copy link
Contributor

left a comment

thanks @blorente

@@ -66,7 +72,7 @@ def run(self):
warnings.filterwarnings(action='ignore', message=message_regexp)

# TODO https://github.com/pantsbuild/pants/issues/7205
if global_bootstrap_options.enable_pantsd and not self.will_terminate_pantsd():
if self._should_run_with_pantsd(global_bootstrap_options):
try:
return RemotePantsRunner(self._exiter, self._args, self._env, options_bootstrapper).run()
except RemotePantsRunner.Fallback as e:

This comment has been minimized.

Copy link
@ity

ity Jun 24, 2019

Contributor

inlining of the LocalPantsRunner import can be moved to right before its used below

@stuhood
Copy link
Member

left a comment

Thanks.

@stuhood stuhood merged commit 3898855 into pantsbuild:master Jun 24, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

blorente added a commit to blorente/pants that referenced this pull request Jun 25, 2019

Add concurrent flag, which overrides --enable-pantsd (pantsbuild#7944)
### Problem

We want for users to be able to run concurrent pants runs. This, essentially, means turning off pantsd. This PR implements that flag, and just doesn't even try to use pantsd if `--concurrent` is set.

Some more context: pantsbuild#7913 (comment)

blorente added a commit to blorente/pants that referenced this pull request Jun 26, 2019

Add concurrent flag, which overrides --enable-pantsd (pantsbuild#7944)
### Problem

We want for users to be able to run concurrent pants runs. This, essentially, means turning off pantsd. This PR implements that flag, and just doesn't even try to use pantsd if `--concurrent` is set.

Some more context: pantsbuild#7913 (comment)

@illicitonion illicitonion removed this from the 1.17.x milestone Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.