Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 select.select() code #7964

Merged
merged 1 commit into from Jun 28, 2019

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

commented Jun 27, 2019

In #7882, we started using the much more efficient selectors module with Python 3 instead of select.select(). We may now remove the Python 2 code that was still using the original select.select().

@stuhood

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Ditto holding off for a few days and/or waiting for @blorente to chime in.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

Ditto holding off for a few days and/or waiting for @blorente to chime in.

Likewise, I think this is unlikely to cause a merge conflict because we have been using the Python 3 selector code for the past two weeks stably and I don't anticipate any changes having to be made to these particular lines for to stabilize 1.17.x. Fine waiting if we still think that's the right choice, though.

@blorente
Copy link
Contributor

left a comment

Looks good, I will merge since CI is green.

@blorente blorente merged commit c41dee9 into pantsbuild:master Jun 28, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:remove-py2-select branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.