Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `future` library #7988

Merged
merged 5 commits into from Jul 2, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jul 1, 2019

No description provided.

@Eric-Arellano Eric-Arellano requested review from stuhood, benjyw and mateor Jul 1, 2019

@benjyw

benjyw approved these changes Jul 1, 2019

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:remove-future branch from 8650a82 to 389720e Jul 1, 2019

@Eric-Arellano Eric-Arellano merged commit a9e5464 into pantsbuild:master Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:remove-future branch Jul 2, 2019

Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Jul 3, 2019

Eric-Arellano added a commit that referenced this pull request Jul 3, 2019

Fix bad `with_traceback()` change from #7988 (#8004)
Python does not allow keyword args for several builtins, including `with_traceback`. This was not detected as an issue in #7988 because the test was already flaky, and this only causes an additional error when the test flakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.