Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill all uses of t.c.collections.OrderedDict. #8003

Merged

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

commented Jul 3, 2019

We can rely on the stdlib instead now.

Kill all uses of t.c.collections.OrderedDict.
We can rely on the stdlib instead now.
@Eric-Arellano
Copy link
Contributor

left a comment

Even better than this, there is no need for OrderedDict in Py 3.6+ because they are ordered by insertion order. If you want a different ordering, you can sort it into a new dictionary.

Fine if you want to wait to make this change.

@jsirois

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

We have a much larger number of uses of OrderedDict (29). I'll leave this in to stick to the subject and leave the switch to dict for a cleanup of that nature in the future.

@jsirois jsirois merged commit d66d8ba into pantsbuild:master Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:t.c.collections.OrderedDict/kill branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.