Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad `with_traceback()` change from #7988 #8004

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

commented Jul 3, 2019

Python does not allow keyword args for several builtins, including with_traceback. This was not detected as an issue in #7988 because the test was already flaky, and this only causes an additional error when the test flakes.

@Eric-Arellano Eric-Arellano requested a review from jsirois Jul 3, 2019

@jsirois

jsirois approved these changes Jul 3, 2019

@Eric-Arellano Eric-Arellano merged commit e64fd61 into pantsbuild:master Jul 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-with-traceback branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.