Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add utf-8 encoding to thrift-generated python files #8022
When you have utf-8 characters in docstrings inside thrift files, these make it to the generated python sources. Those sources should be utf-8 encoded as well.
Passed the option
We now add the "compile utf-8" header to every non-
Eric-Arellano left a comment
Good change. Even if the thrift files will be used by Py3, it is totally safe to still have this header line. Because this is generated code (where verbosity matters less), I think it’s good to always no matter what include the header.