Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated logger.warn calls with logger.warning #8033

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@illicitonion
Copy link
Contributor

commented Jul 10, 2019

No description provided.

@illicitonion illicitonion requested review from blorente and Eric-Arellano Jul 10, 2019

@Eric-Arellano
Copy link
Contributor

left a comment

Yay! Feel free to also switch these to use f-strings :) totally okay to keep this a more focused scope though.

@ity

ity approved these changes Jul 10, 2019

Copy link
Contributor

left a comment

nice!

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Think this needs a rebase against master to land. The Rust - Python interface changed, so a restart of individual shards will fail.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/warn-to-warning branch from c3e7de9 to d343734 Jul 19, 2019

@illicitonion illicitonion merged commit 0ead426 into pantsbuild:master Jul 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/warn-to-warning branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.