Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fail for missing classpath entries with hermetic execution. #8037
When hermetic execution is used for
Convert the warning into an error, and fix all of the issues exposed by that change:
Hermetic execution has improved validation that should help to catch additional bugs in the future.
Jul 13, 2019
All the commits are useful to review independently (and roughly correspond to the bullets above).
There are a few ways that this could maybe be broken up into multiple PRs if folks feel that that would be useful: in particular, the bootstrap changes could be broken out as pre-work.
ity left a comment
high level, looks good to me - i havent dug into the travis failures.