Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add lmdb_store to travis cache #8042
Eric-Arellano left a comment
To be extra defensive at the risk of repetition / obviousness: we do not have the risk of a change in a source file not triggering a re-run of the test, correct? I believe this to be true because:
The directory where we materialize the files (for local execution) or the machine being used for remote execution, only has files which were declared as dependencies. This means that there are a few ways to change files and not invalidate the cache, but they're all pretty sketchy. They all rely on looking up files outside of the working directory; if your test does something like
Outside of the tests themselves, rules can potentially do sketchy things. If you had a rule which called
For the most part, our guard rails against doing this are code review. At some point we may introduce some kind of sandboxing to enforce those constraints, rather than rely on people not doing the wrong thing.
Got it. Thank you for explaining that all.
It sounds like my main concern—that someone makes a normal change to