Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ShardedLmdb takes max size in bytes, not pages" #8044

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@stuhood
Copy link
Member

commented Jul 11, 2019

Reverts #8038

@@ -159,7 +156,7 @@ impl ShardedLmdb {
.set_flags(EnvironmentFlags::NO_SYNC | EnvironmentFlags::NO_TLS)
// 2 DBs; one for file contents, one for leases.
.set_max_dbs(2)
.set_map_size(max_size_bytes / page_size::get())
.set_map_size(max_size)

This comment has been minimized.

Copy link
@stuhood

stuhood Jul 12, 2019

Author Member

My read of the docs for this method is that it is supposed to be bytes, but that it should be a multiple of the page size.

https://docs.rs/lmdb/0.8.0/lmdb/struct.EnvironmentBuilder.html#method.set_map_size

@stuhood stuhood merged commit 6650ef8 into master Jul 12, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the revert-8038-dwagnerhall/shardedlmdb-maxsizebytes branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.