Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for speculation as a viable command runner. #8050

Merged
merged 3 commits into from Jul 16, 2019

Conversation

@hrfuller
Copy link
Contributor

commented Jul 15, 2019

Problem

This is a follow up to #7992 to add CLI flags for controlling usage of speculation.

Solution

Add two new advanced cli flags under the process_execution scope:

  • process_execution_speculation_timeout_ms takes a timeout after which we would speculate (if enabled).
  • process_execution_speculation is a tri-state flag, which selects the type of speculation, or disables it. This maintains the possibility of remote only execution without any speculation.

Both flags have defaults but will only have any effect if the remote_execution switch is flipped on.

Result

Users have control of the speculation mode and timeout parameter.

hrfuller added some commits Jul 12, 2019

wire options through to rust engine. logic around command_runner sele…
…ction based on remote execution and speculation flags
@hrfuller

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@stuhood @illicitonion (also anyone else you think would have input) reviews would be helpful.

@hrfuller

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

Is it worthwhile to add an integration test for this?

@illicitonion
Copy link
Contributor

left a comment

Works for me!

I'll let you settle the ms vs s debate - my personal preference goes:
consistency > ms > s

Show resolved Hide resolved src/rust/engine/src/context.rs Outdated
@hrfuller

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@stuhood ready for merge.

@stuhood stuhood merged commit 3514365 into pantsbuild:master Jul 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:hfuller/speculation-by-default branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.