Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provides clauses for the new zinc deps from #7506. #8055

Merged

Conversation

@stuhood
Copy link
Member

commented Jul 16, 2019

In order to publish zinc, its dependencies must name their artifacts via provides clauses.

@stuhood stuhood requested a review from cosmicexplorer Jul 16, 2019

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

The shard failure is due to #8056, which is now fixed in master. Will merge after review.

@cosmicexplorer
Copy link
Contributor

left a comment

Thanks for doing this!

@stuhood stuhood merged commit 7e5eade into pantsbuild:master Jul 16, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@stuhood stuhood deleted the twitter:stuhood/provides-clauses-for-zinc-deps branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.