Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Google RBE Docker image to allow building sdist wheels #8059

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@Eric-Arellano
Copy link
Contributor

commented Jul 16, 2019

Google's Ubuntu image does not have the dependencies necessary to install psutil, scandir, pyopenssl, setproctitle, and python-Levenshtein, as documented in #8057.

Turns out, all that's necessary to fix this is installing build-essential. The fix was confirmed locally by building this image then running docker run -t remote_execution sh -c 'pip3 install pex; pex setproctitle scandir psutil python-Levenshtein'.

Will close #8057.

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Skipping CI on this one, as it's not used by any actual code yet. Will link to this new image in #8051 once it gets published to Dockerhub.

# Copyright 2019 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

FROM gcr.io/cloud-marketplace/google/rbe-ubuntu16-04@sha256:da0f21c71abce3bbb92c3a0c44c3737f007a82b60f8bd2930abc55fe64fc2729

This comment has been minimized.

Copy link
@stuhood

stuhood Jul 17, 2019

Member

Do we want to base on this, or on some other image that we are more familiar with? Is there value in figuring out what the base for travis's image is, and starting there instead?

This comment has been minimized.

Copy link
@Eric-Arellano

Eric-Arellano Jul 17, 2019

Author Contributor

I think that it makes sense to use this as the basis. From what I understand, Google intentionally gave it a limited set of powers with the intention of keeping things as hermetic and simple as possible. In contrast, the Travis images seem to have things irrelevant to us, like STOPSIGNAL SIGINT: https://github.com/travis-ci/worker/blob/master/Dockerfile.

@Eric-Arellano Eric-Arellano requested a review from stuhood Jul 17, 2019

@stuhood stuhood merged commit 2d4db7a into pantsbuild:master Jul 17, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@stuhood

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Kicked off a build of https://cloud.docker.com/u/pantsbuild/repository/docker/pantsbuild/rbe-remote-execution : image name rbe-remote-execution.

Eric-Arellano added a commit to Eric-Arellano/pants that referenced this pull request Jul 17, 2019

Eric-Arellano added a commit that referenced this pull request Jul 18, 2019

Use our docker image from #8059 for remote execution (#8068)
This actually fixes #8057 by using the image created in #8059.

sammy-1234 pushed a commit to sammy-1234/pants that referenced this pull request Jul 18, 2019

Extend Google RBE Docker image to allow building sdist wheels (pantsb…
…uild#8059)

Google's Ubuntu image does not have the dependencies necessary to install `psutil`, `scandir`, `pyopenssl`, `setproctitle`, and `python-Levenshtein`, as documented in pantsbuild#8057.

Turns out, all that's necessary to fix this is installing `build-essential`. The fix was confirmed locally by building this image then running `docker run -t remote_execution sh -c 'pip3 install pex; pex setproctitle scandir psutil python-Levenshtein'`.

Will close pantsbuild#8057.

sammy-1234 pushed a commit to sammy-1234/pants that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.