Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use platform-specific directories for virtualenvs #8073

Conversation

@illicitonion
Copy link
Contributor

commented Jul 19, 2019

This makes it easier to use docker on OSX in-place without having to
delete directories when switching between OSs.

@illicitonion illicitonion requested a review from Eric-Arellano Jul 19, 2019

@stuhood
Copy link
Member

left a comment

There are a buuunch more locations assuming this path, unfortunately:

$ rg '\.venv' | wc -l
18

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/platform-specific-virtualenv branch from 5138d60 to b2250eb Aug 7, 2019

@illicitonion
Copy link
Contributor Author

left a comment

There are a buuunch more locations assuming this path, unfortunately:

$ rg '\.venv' | wc -l
18

I checked, only one of them actually needs updating; done.

@stuhood
stuhood approved these changes Aug 7, 2019

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/platform-specific-virtualenv branch from b2250eb to e73145a Aug 12, 2019

Use platform-specific directories for virtualenvs
This makes it easier to use docker on OSX in-place without having to
delete directories when switching between OSs.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/platform-specific-virtualenv branch from e73145a to 5d8c420 Aug 28, 2019

@illicitonion illicitonion merged commit dbf5851 into pantsbuild:master Aug 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/platform-specific-virtualenv branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.