Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option zipkin-max-span-batch-size #8075

Conversation

@cattibrie
Copy link
Contributor

commented Jul 19, 2019

Problem

py_zipkin sends traces to Zipkin server in batches. Currently, the default value is set to 100 that can be not an optimal number for the number of spans in a trace for pants.

Result

Adding the zipkin-max-span-batch-size option will allow finding the right batch size.

@blorente blorente requested review from illicitonion and stuhood Jul 19, 2019

@stuhood
Copy link
Member

left a comment

Thanks!

@@ -59,7 +59,10 @@ def register_options(cls, register):
register('--zipkin-trace-v2', advanced=True, type=bool, default=False,
help='If enabled, the zipkin spans are tracked for v2 engine execution progress.')
register('--zipkin-service-name-prefix', advanced=True, default='pants',
help='The prefix for service name for Zipkin spans.')
help='The prefix for service name for Zipkin spans.')
register('--zipkin-max-span-batch-size', advanced=True, default=100,

This comment has been minimized.

Copy link
@stuhood

stuhood Jul 19, 2019

Member

Should set a type here: .., type=int, .., which will cause options parsing to do some validation for you.

@cattibrie cattibrie force-pushed the cattibrie:etyurina/DPB-11348-make_zipkin-batch-size-an-option branch from 868b53c to 711f199 Aug 10, 2019

@cattibrie cattibrie force-pushed the cattibrie:etyurina/DPB-11348-make_zipkin-batch-size-an-option branch from 711f199 to cb3d0b6 Aug 12, 2019

@stuhood stuhood merged commit e3f8dfc into pantsbuild:master Aug 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
illicitonion added a commit that referenced this pull request Aug 29, 2019
Add option zipkin-max-span-batch-size (#8075)
### Problem
py_zipkin sends traces to Zipkin server in batches. Currently, the default value is set to 100 that can be not an optimal number for the number of spans in a trace for pants.

### Result
Adding the zipkin-max-span-batch-size option will allow finding the right batch size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.