Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor V2 PEX creation rules #8080

Merged

Conversation

@Eric-Arellano
Copy link
Contributor

commented Jul 20, 2019

#8063 was originally going to result in creating a SourcesPex (in addition to RequirementsPex). In preparation for that, the below refactors were made. Even though the approach to #8063 has changed, these are good changes to make in general and may be useful to porting ./pants binary.

  • Extract out download_pex_bin rule.
  • Rename resolve_requirements.py -> create_requirements_pex.py for more explicit name (and avoid name clash with V1 file).
  • Fix shadowing variable name.
  • Use long CLI args.

@Eric-Arellano Eric-Arellano requested review from stuhood and illicitonion Jul 20, 2019

* Use long CLI args
* Fix shadowing variable name
* Update description of ProcessRequest
@Eric-Arellano

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Even though the approach is changing in #8063 to no longer require this pre-work, this still has good changes to make so am going to merge this.

@Eric-Arellano Eric-Arellano merged commit f9bb8d6 into pantsbuild:master Jul 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:refactor-resolve-requirements branch Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.