Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite `test_git_hooks.py` to be hermetic #8085

Merged
merged 5 commits into from Jul 26, 2019

Conversation

@Eric-Arellano
Copy link
Contributor

commented Jul 21, 2019

This test failed when remoting because it relied on access to several scripts in build-support/bin that were not explicitly declared.

This is fixed by explicitly depending on the scripts. We must jump through some hoops to then copy the scripts into the temporary workdir created by the tests.

@Eric-Arellano
Copy link
Contributor Author

left a comment

Blocked by #8063.

Show resolved Hide resolved build-support/bin/BUILD
@stuhood
Copy link
Member

left a comment

Thanks!

IMO, let's glob all of the non-python files together into one target before merging this though. I understand the motivation for target-per-file, but I'm just not sure that we're going to get useful bash support soon enough to justify targets for bash files.

Show resolved Hide resolved build-support/bin/BUILD

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:fix-test-githooks branch from 6f38631 to 7c3bb6e Jul 24, 2019

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:fix-test-githooks branch 2 times, most recently from 4a3770a to 20af37c Jul 25, 2019

@Eric-Arellano Eric-Arellano merged commit 44c2741 into pantsbuild:master Jul 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-test-githooks branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.