Join GitHub today
Loosen constraints on the jvm heap size for tests in extra_jvm_options #8106
We set the default heap size to 1GB, and there was a test that trusted on that being a consistent number. However, the test doesn't need that to work. It's not testing the actual default heap size, but that we can modify the heap size if we pass an option.
This was causing travis failures: https://pastebin.com/knEMAWm7
Only output a number if the heap size is less than 100MB. We set it to be very small in the target that we are testing.
Hopefully no failures.
stuhood left a comment
The "default" heap size without any options set is ill-defined: it's chosen by the JVM based on the host. So I don't think that checking a range like this necessarily accomplishes what we wanted.
If we want to test this property in particular you could maybe set it to a much more specific value like
So the range here is not important, we just want to check that we haven't overwritten the value set by the machine's default (which, I agree, is unknowable).
This is a good point, I'm guessing this would go under