Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote execution failure to compile C code #8117

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@Eric-Arellano
Copy link
Contributor

commented Jul 27, 2019

tests/python/pants_test/backend/native/subsystems:subsystems was failing with sys/cdefs.h: No such file or directory. Per https://askubuntu.com/a/590832, we can fix this by installing g{cc,++}-multilib.

@Eric-Arellano Eric-Arellano requested review from stuhood and cosmicexplorer Jul 27, 2019

@stuhood
Copy link
Member

left a comment

Thanks!

Sidenote: I'm fine with doing the f-strings changes as separate commits in other PRs, but I didn't realize at first that that is what you'd done here. Should make sure that's clear to reviewers (in a comment maybe).

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:fix-native-subsystems branch from ffade56 to 6f90979 Aug 13, 2019

@Eric-Arellano Eric-Arellano merged commit 80e6cb6 into pantsbuild:master Aug 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:fix-native-subsystems branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.