Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remote execution of unit tests temporarily #8138

Conversation

@stuhood
Copy link
Member

commented Aug 2, 2019

Problem

Remote execution of unit tests under v2 began failing on Thursday afternoon.

Solution

Disable remote execution until #8137 can be resolved.

@stuhood stuhood requested review from benjyw, blorente and Eric-Arellano Aug 2, 2019

@jsirois

jsirois approved these changes Aug 2, 2019

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

I'm not 100% certain that all tests will pass in local mode, so I'm going to wait to see what happens with the unit test shard before merging this.

@stuhood stuhood added this to the 1.19.x milestone Aug 2, 2019

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Unit test shards passed. Merging.

@stuhood stuhood merged commit 24e5f1a into pantsbuild:master Aug 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:stuhood/disable-remote-execution-temporarily branch Aug 2, 2019

stuhood added a commit that referenced this pull request Aug 2, 2019

Disable remote execution of unit tests temporarily. (#8138)
### Problem

Remote execution of unit tests under v2 began failing on Thursday afternoon.

### Solution

Disable remote execution until #8137 can be resolved.

Eric-Arellano added a commit that referenced this pull request Aug 12, 2019

Restore remote execution of unit tests by fixing Firewall (#8162)
In #8138, we turned off remote execution because we mysteriously started getting 403 errors. Turns out that Travis had updated one of its IP addresses without us realizing, so the Google App Engine firewall was giving 403 errors.

This was fixed by updating the Google Cloud Console at https://console.cloud.google.com/appengine/firewall?project=pants-remoting-beta to match the list at https://docs.travis-ci.com/user/ip-addresses/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.