Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add SCM info if scm is available. #8147

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@asherf
Copy link
Contributor

commented Aug 7, 2019

Problem

When SCM is not available (for example, building pex in a docker container where git is not installed) we still add revision & branch info to RunInfo as strings containing 'none' which I believe is bad. since it requires whoever reads this information to special case for the 'none' string.
Screenshot 2019-08-07 12 28 19

Solution

Don't include SCM info if SCM is not available.

Result

SCM information is not included in PEX-INFO/run-info if SCM is not available.

@asherf asherf force-pushed the asherf:scm branch from 175e60f to 130f0a5 Aug 7, 2019

@stuhood
stuhood approved these changes Aug 7, 2019
@jsirois
jsirois approved these changes Aug 7, 2019
@jsirois

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

CI on this one is a blood bath. I'll take a look later tonight. It's pretty much guaranteed your change did not cause all this.

@asherf asherf force-pushed the asherf:scm branch from 130f0a5 to 3a84782 Aug 8, 2019

@jsirois

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@asherf you'll need to rebase to force a new CI run. We're geeting these which can only be reasonably solved that way:

Error: Found 2 versions for s3://ci-public.pantsbuild.org/25697/569134278/pants.pex.py36.osx

@asherf asherf force-pushed the asherf:scm branch 3 times, most recently from 665b1fa to 91e7b26 Aug 8, 2019

@asherf asherf force-pushed the asherf:scm branch from 91e7b26 to b9d138a Aug 10, 2019

@Eric-Arellano Eric-Arellano merged commit 8ec4d9c into pantsbuild:master Aug 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asherf asherf deleted the asherf:scm branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.