Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen test condition #8156

Merged

Conversation

@illicitonion
Copy link
Contributor

commented Aug 9, 2019

We don't actually want to guarantee from serverset that we will
exactly round-robin between servers (which is a property I'm about to
remove), just that we average out to trying them at roughly equal rates.

@pierrechevalier83
Copy link
Contributor

left a comment

Nice! I didn't know about maplit::hashset!. Neat trick 😄

@blorente
Copy link
Contributor

left a comment

Cool :)

@stuhood
stuhood approved these changes Aug 9, 2019
Loosen test condition
We don't actually want to guarantee from serverset that we will
_exactly_ round-robin between servers (which is a property I'm about to
remove), just that we average out to trying them at roughly equal rates.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/deflaking/retries branch from c8fda45 to d7257d5 Aug 12, 2019

@illicitonion illicitonion merged commit f0fd0a3 into pantsbuild:master Aug 12, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/deflaking/retries branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.