Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyYAML to generate .travis.yml #8163

Merged
merged 8 commits into from Aug 20, 2019

Conversation

@Eric-Arellano
Copy link
Contributor

commented Aug 12, 2019

Will close #8112.

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:python-generate-travis branch 2 times, most recently from 301200d to 2e31b65 Aug 14, 2019

@Eric-Arellano Eric-Arellano force-pushed the Eric-Arellano:python-generate-travis branch from 2e31b65 to d0da49c Aug 18, 2019

@Eric-Arellano Eric-Arellano changed the title WIP: Use PyYAML to generate our .travis.yml Use PyYAML to generate .travis.yml Aug 18, 2019

@Eric-Arellano Eric-Arellano marked this pull request as ready for review Aug 18, 2019

build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved


def main() -> None:
generated_yaml = yaml.dump({

This comment has been minimized.

Copy link
@cosmicexplorer

cosmicexplorer Aug 18, 2019

Contributor

This is so simple! I love it!

@Eric-Arellano
Copy link
Contributor Author

left a comment

Thanks @cosmicexplorer for the review!

build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
@stuhood
Copy link
Member

left a comment

Thanks! I will not miss the hand editing of YAML (oh, the irony).

As discussed offline, I ignored the generated file.

build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Show resolved Hide resolved
build-support/bin/generate_travis_yml.py Outdated Show resolved Hide resolved

@Eric-Arellano Eric-Arellano merged commit fe6a2d3 into pantsbuild:master Aug 20, 2019

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:python-generate-travis branch Aug 20, 2019

patliu85 added a commit to twitter/pants that referenced this pull request Aug 20, 2019
blorente added a commit that referenced this pull request Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.