Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.20.0dev2 deprecations #8172

Merged
merged 7 commits into from Aug 15, 2019

Conversation

@wisechengyi
Copy link
Contributor

commented Aug 13, 2019

No description provided.

wisechengyi added 6 commits Aug 14, 2019

@wisechengyi wisechengyi changed the title [WIP] Remove 1.20.0dev2 deprecations Remove 1.20.0dev2 deprecations Aug 15, 2019

@wisechengyi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Ready for review now. Thanks!

@wisechengyi wisechengyi requested review from stuhood, benjyw and jsirois Aug 15, 2019

@stuhood
Copy link
Member

left a comment

Thanks Yi!

If this wasn't already green, I'd suggest also landing the dev2 prep in this PR: up to you.

@wisechengyi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

Already green, so will just land this first. Thanks!

@wisechengyi wisechengyi merged commit aa47d93 into pantsbuild:master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:1.20.0dev2_dep branch Aug 15, 2019

patliu85 added a commit to twitter/pants that referenced this pull request Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.